Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

reduce $crFound check at AbstractSerializer::getLine() #309

Closed
wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Contributor

No description provided.

@samsonasik samsonasik changed the title reduce $crFound at AbstractSerializer::getLine() reduce $crFound check at AbstractSerializer::getLine() Jul 4, 2018
@weierophinney
Copy link
Member

I disagree with this change. The four distinct conditionals in the while loop are for a reason: to detail the specific carriage return/line feed combinations we scan for, and the impact each has when detecting a line. Moving one part of the conditional inside the other makes understanding the combinations more difficult.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants