This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Workaround PHP bug #63206 in Stream::setStream method #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ste93cry Umm... that's not the PR template we use... and the package is licensed BSD-3-Clause; we're not in a position to dual-license. Can you clarify the license before we merge, please? |
|
Sorry I copy-pasted a template from another repository I used to contribute to. My code is released under any license you use, so feel free to do whatever you want. |
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2018
weierophinney
added a commit
that referenced
this pull request
Jul 19, 2018
|
Thanks, @ste93cry! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #298 by removing the usage of the second argument of the
set_error_handlerfunction and moves the check of the level of the raised error inside the error handler callback.