This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Implement PSR-17 #326
Merged
Implement PSR-17 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
to weierophinney/zend-diactoros
that referenced
this pull request
Sep 5, 2018
thexpand
suggested changes
Sep 5, 2018
src/StreamFactory.php
Outdated
| @@ -0,0 +1,45 @@ | |||
| <?php | |||
| /** | |||
| * @see https://github.com/zendframework/zend-expressive for the canonical source repository | |||
There was a problem hiding this comment.
Shouldn't this be zend-diactoros instead of zend-expressive?
There was a problem hiding this comment.
Arrgggghhh! Yes. I'll fix that momentarily.
src/StreamFactory.php
Outdated
| /** | ||
| * @see https://github.com/zendframework/zend-expressive for the canonical source repository | ||
| * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (https://www.zend.com) | ||
| * @license https://github.com/zendframework/zend-expressive/blob/master/LICENSE.md New BSD License |
There was a problem hiding this comment.
zend-diactoros instead of zend-expressive
src/UploadedFileFactory.php
Outdated
| @@ -0,0 +1,31 @@ | |||
| <?php | |||
| /** | |||
| * @see https://github.com/zendframework/zend-expressive for the canonical source repository | |||
There was a problem hiding this comment.
zend-diactoros instead of zend-expressive
src/UploadedFileFactory.php
Outdated
| /** | ||
| * @see https://github.com/zendframework/zend-expressive for the canonical source repository | ||
| * @copyright Copyright (c) 2018 Zend Technologies USA Inc. (https://www.zend.com) | ||
| * @license https://github.com/zendframework/zend-expressive/blob/master/LICENSE.md New BSD License |
There was a problem hiding this comment.
zend-diactoros instead of zend-expressive
froschdesign
reviewed
Sep 6, 2018
src/RequestFactory.php
Outdated
|
|
||
| class RequestFactory implements RequestFactoryInterface | ||
| { | ||
| public function createRequest(string $method, $uri) : RequestInterface |
There was a problem hiding this comment.
Does this work without @inheritdoc? Also for the exceptions?
There was a problem hiding this comment.
@xtreamwayz
Can you answer this question?
There was a problem hiding this comment.
I'll add the @inheritDoc annotations.
geerteltink
approved these changes
Sep 6, 2018
This patch implements the PSR-17 interfaces, and tests them against the http-interop/http-factory-tests integration test suite. As part of the change, we are also able to remove the additional integration test dependency when testing against the PSR-7 integration tests. Those tests rely on PSR-17 factories, which we now provide, and map within the `phpunit.xml.dist` file. As such, both PSR-7 and PSR-17 integration tests will run for every build target. All PSR-17 implementations are alongside the PSR-7 classes they create. Also adds php nightly build to matrix, to ensure we are prepared for PHP 7.3.
weierophinney
force-pushed
the
feature/psr-17
branch
from
70b313a
to
190349f
Compare
|
URLs fixed, and |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the PSR-17 interfaces, and tests them against the http-interop/http-factory-tests integration test suite.
As part of the change, we are also able to remove the additional integration test dependency when testing against the PSR-7 integration tests. Those tests rely on PSR-17 factories, which we now provide, and map within the
phpunit.xml.distfile. As such, both PSR-7 and PSR-17 integration tests will run for every build target.All PSR-17 implementations are alongside the PSR-7 classes they create.
Also adds php nightly build to matrix, to ensure we are prepared for PHP 7.3.