This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fixed serverRequest factory #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires a unit test, as well as an integration test that runs through a standard HTTP request flowing in from at least the internal PHP development server. |
|
Ok, I've added a couple of tests. |
Ocramius
suggested changes
Nov 26, 2018
Ocramius
approved these changes
Dec 1, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 3, 2018
Fixed serverRequest factory
weierophinney
added a commit
that referenced
this pull request
Dec 3, 2018
|
Thanks, @oscarotero! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
ServerRequestFactorythat always creates a server request withphp://inputas the body stream.