Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Hotfix: marshalHeadersFromSapi function #370

Merged
merged 7 commits into from
Oct 8, 2019
Merged

Hotfix: marshalHeadersFromSapi function #370

merged 7 commits into from
Oct 8, 2019

Conversation

michalbundyra
Copy link
Member

  • integer keys should be ignored
  • _ should be changed to - in key (also for CONTENT_* headers)

Fixes #369

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

weierophinney
weierophinney suggested changes Oct 8, 2019
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple changes are unrelated.

src/functions/marshal_headers_from_sapi.php Outdated Show resolved Hide resolved
src/functions/marshal_headers_from_sapi.php Outdated Show resolved Hide resolved
weierophinney
weierophinney approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@michalbundyra michalbundyra added this to the 2.1.4 milestone Oct 8, 2019
@weierophinney weierophinney merged commit a16378c into zendframework:master Oct 8, 2019
weierophinney added a commit that referenced this pull request Oct 8, 2019
@weierophinney
Merge branch 'hotfix/370-marshal-headers-from-sapi' into develop
5c10156 
Forward port #370

Conflicts:
	CHANGELOG.md
@michalbundyra michalbundyra deleted the hotfix/marshal-headers-from-sapi branch October 8, 2019 20:14
@Jean85 Jean85 mentioned this pull request Oct 9, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weierophinney weierophinney weierophinney approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.

BUG: marshalHeadersFromSapi assume all SERVER keys are strings
2 participants
@michalbundyra @weierophinney