-
Notifications
You must be signed in to change notification settings - Fork 152
[cs] Place CS rules in config file #38
[cs] Place CS rules in config file #38
Conversation
👍 |
@@ -25,7 +25,7 @@ | |||
}, | |||
"require-dev": { | |||
"phpunit/PHPUnit": "~4.6", | |||
"squizlabs/php_codesniffer": "~2.0" | |||
"squizlabs/php_codesniffer": "^2.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why this specific version and up? What changed specifically with 2.3.1 that is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long array rule not exists before 2.3.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea they didn't follow semantic versioning about to raise feature number when new sniffs are added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, cool; was just curious. :)
[cs] Place CS rules in config file
Supersede and close #28