This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
improve header validation speed #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // 32-126, 128-254 === visible | ||
| // 127 === DEL (disallowed) | ||
| // 255 === null byte (disallowed) | ||
| if (preg_match('/[^\x09\x0a\x0d\x20-\x7E\x80-\xFE]/', $value)) { |
There was a problem hiding this comment.
extract the regex as static $regex = '....' improve something?
There was a problem hiding this comment.
I don't see any difference.
There was a problem hiding this comment.
There won't be a difference. PHP's PCRE caches regexen that it encounters, so subsequent matches using the same expressions will not need re-compilation.
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
improve header validation speed
weierophinney
added a commit
that referenced
this pull request
Jun 4, 2015
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
forloop with regular expressions brought visible performance improvement to header validation.See simple benchmark: https://gist.github.com/mtymek/660b388db0c5b9d63bc0