This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Remove casting prior to JSON serialization #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
weierophinney
changed the title
As noted on zendframework#63, scalars and nulls can be serialized by PHP, and most (all?) client-side parsers will deserialize them correctly. As such, the more correct route is to pass them verbatim to `json_encode()` instead of casting them to arrays and/or objects.
weierophinney
force-pushed
the
hotfix/simplify-json-casting
branch
from
58a8868
to
050e889
Compare
|
Somehow a 100% coverage dropped to 100% leading to a -0.03% change. Stupid coveralls! |
weierophinney
added a commit
that referenced
this pull request
Jun 25, 2015
weierophinney
added a commit
that referenced
this pull request
Jun 25, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted on #63, casting nulls and scalars to objects and arrays, respectively, is not necessary, and likely unwanted; it could even be considered buggy behavior.
This patch eliminates the casting entirely, and updates the tests to ensure that scalars are encoded verbatim.