This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
[#80] Ensure Uri::with*() methods validate
#85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If methods should only accept a string, ensure they raise an exception in such cases. Fixes zendframework#80.
weierophinney
added a commit
that referenced
this pull request
Aug 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If methods should only accept a string, ensure they raise an exception in such cases.
This affects
withFragment(),withScheme(),withUserInfo(), andwithHost(), each of which were previously passing non-string input through without change, and, in some cases, raising errors as a result, while in other cases casting to string in unexpected ways.Since PSR-7 documents these methods as only accepting strings, raising an
InvalidArgumentExceptionfor non-string input is a reasonable and consistent approach.Fixes #80.