Set the Content-Length header when emitting the response #88
Conversation
| ->expects($this->any()) | ||
| ->method('withHeader') | ||
| ->willReturnSelf(); | ||
|
|
There was a problem hiding this comment.
Not really happy with that, mocking the whole world to get an integration test passing isn't really great. Didn't have a lot of time to think of a better solution.
There was a problem hiding this comment.
With some of these integration tests, it seems like the only way to do it. They do get lengthy, though!
We might consider porting them to Prophecy at some point (we're using it extensively in the ZF3 component rewrites, and in Expressive), but that's something for a lull time in development.
|
The tests should be green now. Please review the tests and let me know if you want me to apply a different solution: auto-adding the |
Set the Content-Length header when emitting the response
Fixes #84
One test is failing because of a side-effect in unrelated tests. Need to work on it, but if you have an idea on the best way to fix it's welcome, I'm not familiar with everything yet.