PHP 7.1 - typehints, return types, strict types

[michalbundyra]

The PR destination should be changes once branch release-3.0.0 is created.

Also we should update zend-expressive-router to ^3.0.0@dev once zendframework/zend-expressive-router#41 is merged.

Unfortunately one test is failing and I don't know how to fix it right now.
@weierophinney any ideas?

Note:

• PHP 7.1 - typehints, return types, strict types zend-expressive-fastroute#41
• PHP 7.1 - typehints, return types, strict types zend-expressive-zendrouter#30

are both fine.

[weierophinney]

Unfortunately one test is failing and I don't know how to fix it right now.
@weierophinney any ideas?

Looking into it now. I think it may have to do with how the AuraRouter populstaes the RouteResult.

[weierophinney]

Unfortunately one test is failing and I don't know how to fix it right now.
@weierophinney any ideas?

Looking into it now. I think it may have to do with how the AuraRouter populstaes the RouteResult.

RouteResult::isMethodFailure() returns false if [] == $this->allowedMethods... which is precisely what the test sets up. This either means:

• RouteResult::isMethodFailure()'s logic is incorrect, or
• AuraRouter::match() is incorrectly populating the RouteResult.

Looking at the logic in RouteResult, my inclination is that that logic is wrong. It should be looking for ['*'] === $this->allowedMethods.

[weierophinney]

Interestingly, after pushing an update to zend-expressive-router to fix that particular issue, I get three different failures in this package. Working on those now.