This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Ensure all paths for route result generation are tested #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two paths were still using incorrect syntax, so this patch adds tests that will exercise those paths, and also fixes the bad syntax.
|
|
||
| $this->auraMatcher->match($request)->willReturn($auraRoute); | ||
|
|
||
| $middleware = $this->getMiddleware(); |
There was a problem hiding this comment.
The $middleware variable is not used
There was a problem hiding this comment.
Will remove on merge; nice catch!
| 'bar' => 'baz', | ||
| ]); | ||
|
|
||
| $this->auraMatcher->match($request)->willReturn($auraRoute); |
There was a problem hiding this comment.
Should we have $request->reveal() here?
There was a problem hiding this comment.
Yes... which is odd, as that should not work correctly otherwise...
There was a problem hiding this comment.
Please see my PR:
https://github.com/zendframework/zend-expressive-zendrouter/pull/32/files
I'm not mocking the request, maybe you should do the same here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two paths were still using incorrect syntax, so this patch adds tests that will exercise those paths, and also fixes the bad syntax.