This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Request OPTIONS fix to return all allowed methods #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface of the latest zend-expressive-router has been changed. We can't get matched middleware from RouteResult but we can get matched route, and then from route we can get middleware.
The test is pulled from zend-expressive-router library OPTIONS request should return response with all allowed methods for the matching path
geerteltink
previously requested changes
Mar 2, 2018
composer.json
Outdated
| "repositories": [ | ||
| { | ||
| "type": "git", | ||
| "url": "https://github.com/webimpress/zend-expressive-router" |
There was a problem hiding this comment.
A reminder to remove this before merging.
Pins to 3.0.0rc1, and updates new test case based on name change in that release.
weierophinney
dismissed
geerteltink’s stale review
Updated composer.json per @xtreamwayz.
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2018
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests are pulled from zend-expressive-router repository.
See: zendframework/zend-expressive-router#53