This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Allow existing PDO service to be used #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a narrative description of what you are trying to accomplish:
Why is the new feature needed? What purpose does it serve?
Allows existing PDO service to be used. This will allow us to reuse existing pdo services instead of opening up a second connection for oauth.
How will users use the new feature?
Passing a service name in the PDO config key instead of connection params.
Add tests for the new feature.
Add documentation for the new feature.
Add a
CHANGELOG.mdentry for the new feature.Note: Will add Docs and Changelog entry once PR #40 is merged.