Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

use stable version 1.0.0 of nikic/fast-route, no code changes since 0.8.0 #17

Merged
merged 1 commit into from
Jun 16, 2016

Conversation

sandrokeil
Copy link
Contributor

The package maintainer has nothing changed since 0.8.0.

@@ -19,7 +19,7 @@
},
"require": {
"php": "^5.5 || ^7.0",
"nikic/fast-route": "^0.8.0",
"nikic/fast-route": "^1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be ^1.0?

EDIT: nvm, got it mixed up with ~1.0.0.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ^0.8.0 || ^1.0.0 ? @sandrokeil already mentioned: nothing has changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, stable FTW. Now merging/tagging

@bakura10
Copy link
Contributor

Hi,

Can this be merged? ping @weierophinney

@Ocramius Ocramius self-assigned this Jun 16, 2016
@Ocramius Ocramius added this to the 1.2.0 milestone Jun 16, 2016
@Ocramius Ocramius merged commit e148959 into zendframework:develop Jun 16, 2016
Ocramius added a commit that referenced this pull request Jun 16, 2016
@Ocramius
Copy link
Member

@sandrokeil included this in 1.2.0, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants