Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fix null value throwing error #41

Merged
merged 4 commits into from Dec 11, 2018
Merged

Fix null value throwing error #41

merged 4 commits into from Dec 11, 2018

Conversation

internalsystemerror
Copy link
Contributor

This fixes: #40

See issue for further information.

@weierophinney
Copy link
Member

Please add a test for this new behavior; thanks!

@internalsystemerror @weierophinney
Fix null value throwing error
9d6a1ad 
This fixes: #40
@internalsystemerror @weierophinney
Remove whitespace
13cc944
@weierophinney
Adds test validating null values result in content-less tags
ba20888 
Test for #41

Also modifies the docblock of normalizeConstantValue to no longer
reference `null` values.
@weierophinney
Adds CHANGELOG entry for #41
e29eacd
@weierophinney
Copy link
Member

I have added tests and a changelog entry, and pushed them to your branch.

@weierophinney weierophinney merged commit e29eacd into zendframework:master Dec 11, 2018
weierophinney added a commit that referenced this pull request Dec 11, 2018
@weierophinney
Merge branch 'hotfix/41-null-value-casting'
f17aad0 
Close #41
Fixes #40
weierophinney added a commit that referenced this pull request Dec 11, 2018
@weierophinney
Merge branch 'hotfix/41-null-value-casting' into develop
31250bd 
Forward port #41
@internalsystemerror
Copy link
Contributor Author

@weierophinney thanks, been extremely busy so I doubt I'll get much time to get back to any of my PRs for a few months still

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extracting a collection of objects where one contains a NULL value causes XML renderer to error
2 participants
@internalsystemerror @weierophinney