Test to cover zendframework/zend-expressive#371

[weierophinney]

Creates an integration test to attempt to recreate the problem reported in zendframework/zend-expressive#371. It sets up the following conditions:

• A request method that can provide body content
• A request body with JSON content
• A Content-Type request header with the value application/json;charset=utf-8

It then passes the request to the BodyParams middleware, and validates that the request received by the delegate has the parsed contents.

Unfortunately... it does not validate the issue reported, as the test passes.

[weierophinney]

Ping @ezimuel ; can you check this?

Also, for any who are experiencing the issue, how are you composing the BodyParamsMiddleware into your application? I have tested this in an API, where I have routes like the following:

$app->patch('/books/{id:' . $uuidRegex . '}', [
    Books\Middleware\AuthorizationMiddleware::class,
    Zend\Expressive\Helper\BodyParams\BodyParamsMiddleware::class,
    Books\Middleware\UpdateBookValidationMiddleware::class,
    Books\Middleware\UpdateBookMiddleware::class
]);

Note that this is:

• a PATCH request
• with a middleware pipeline in place
• and the BodyParamsMiddleware is before the actual middleware to execute

This has been working perfectly for me on both v1 and v2 versions of Expressive. The content submitted is always parsed correctly and pushed into the request. My suspicion for those affected is that the middleware pipeline is not properly setup.

[geerteltink]

LGTM

What is the status on this? Can I merge it and close zendframework/zend-expressive#371?

[weierophinney]

@xtreamwayz I'll merge today.