Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Commit

Permalink
Merge pull request #34 from webimpress/improvement/import-internals
Browse files Browse the repository at this point in the history
Import internal functions and constants + optimize imports
  • Loading branch information
Geert Eltink committed Mar 15, 2018
2 parents 26f8aaa + 9e79780 commit 679f00e
Show file tree
Hide file tree
Showing 12 changed files with 58 additions and 14 deletions.
1 change: 0 additions & 1 deletion src/Extension/EscaperExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
use League\Plates\Engine;
use League\Plates\Extension\ExtensionInterface;
use Zend\Escaper\Escaper;
use Zend\Escaper\Exception\InvalidArgumentException;

class EscaperExtension implements ExtensionInterface
{
Expand Down
4 changes: 3 additions & 1 deletion src/Extension/UrlExtensionFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@
namespace Zend\Expressive\Plates\Extension;

use Psr\Container\ContainerInterface;
use Zend\Expressive\Helper\UrlHelper;
use Zend\Expressive\Helper\ServerUrlHelper;
use Zend\Expressive\Helper\UrlHelper;
use Zend\Expressive\Plates\Exception\MissingHelperException;

use function sprintf;

/**
* Factory for creating a UrlExtension instance.
*/
Expand Down
10 changes: 9 additions & 1 deletion src/PlatesEngineFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@

namespace Zend\Expressive\Plates;

use Psr\Container\ContainerInterface;
use League\Plates\Engine as PlatesEngine;
use League\Plates\Extension\ExtensionInterface;
use Psr\Container\ContainerInterface;
use Zend\Expressive\Helper;

use function class_exists;
use function get_class;
use function gettype;
use function is_array;
use function is_object;
use function is_string;
use function sprintf;

/**
* Create and return a Plates engine instance.
*
Expand Down
9 changes: 9 additions & 0 deletions src/PlatesRenderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@
use Zend\Expressive\Template\TemplatePath;
use Zend\Expressive\Template\TemplateRendererInterface;

use function get_class;
use function gettype;
use function is_object;
use function is_string;
use function sprintf;
use function trigger_error;

use const E_USER_WARNING;

/**
* Template implementation bridging league/plates
*/
Expand Down
5 changes: 4 additions & 1 deletion src/PlatesRendererFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@

namespace Zend\Expressive\Plates;

use Psr\Container\ContainerInterface;
use League\Plates\Engine as PlatesEngine;
use Psr\Container\ContainerInterface;

use function is_array;
use function is_numeric;

/**
* Create and return a Plates template instance.
Expand Down
6 changes: 6 additions & 0 deletions test/ExceptionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@
use Zend\Expressive\Plates\Exception\ExceptionInterface;
use Zend\Expressive\Template\Exception\ExceptionInterface as TemplateExceptionInterface;

use function basename;
use function glob;
use function is_a;
use function strrpos;
use function substr;

class ExceptionTest extends TestCase
{
public function testExceptionInterfaceExtendsTemplateExceptionInterface() : void
Expand Down
5 changes: 0 additions & 5 deletions test/Extension/EscaperExtensionFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,8 @@
use Psr\Container\ContainerInterface;
use Zend\Escaper\Escaper;
use Zend\Escaper\Exception\InvalidArgumentException;
use Zend\Expressive\Helper\ServerUrlHelper;
use Zend\Expressive\Helper\UrlHelper;
use Zend\Expressive\Plates\Exception\MissingHelperException;
use Zend\Expressive\Plates\Extension\EscaperExtension;
use Zend\Expressive\Plates\Extension\EscaperExtensionFactory;
use Zend\Expressive\Plates\Extension\UrlExtension;
use Zend\Expressive\Plates\Extension\UrlExtensionFactory;

class EscaperExtensionFactoryTest extends TestCase
{
Expand Down
2 changes: 2 additions & 0 deletions test/Extension/EscaperExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
use Zend\Escaper\Escaper;
use Zend\Expressive\Plates\Extension\EscaperExtension;

use function is_array;

class EscaperExtensionTest extends TestCase
{
public function testRegistersEscaperFunctionsWithEngine()
Expand Down
2 changes: 1 addition & 1 deletion test/Extension/UrlExtensionFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@

namespace ZendTest\Expressive\Plates\Extension;

use Psr\Container\ContainerInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\Prophecy\ProphecyInterface;
use Psr\Container\ContainerInterface;
use Zend\Expressive\Helper\ServerUrlHelper;
use Zend\Expressive\Helper\UrlHelper;
use Zend\Expressive\Plates\Exception\MissingHelperException;
Expand Down
4 changes: 3 additions & 1 deletion test/PlatesEngineFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@

namespace ZendTest\Expressive\Plates;

use Psr\Container\ContainerInterface;
use League\Plates\Engine as PlatesEngine;
use League\Plates\Extension\ExtensionInterface;
use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\Prophecy\ProphecyInterface;
use Psr\Container\ContainerInterface;
use stdClass;
use Zend\Expressive\Helper\ServerUrlHelper;
use Zend\Expressive\Helper\UrlHelper;
Expand All @@ -23,6 +23,8 @@
use Zend\Expressive\Plates\Extension\UrlExtension;
use Zend\Expressive\Plates\PlatesEngineFactory;

use function is_string;

class PlatesEngineFactoryTest extends TestCase
{
/** @var ContainerInterface|ProphecyInterface */
Expand Down
10 changes: 8 additions & 2 deletions test/PlatesRendererFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,26 @@

namespace ZendTest\Expressive\Plates;

use Psr\Container\ContainerInterface;
use League\Plates\Engine as PlatesEngine;
use LogicException;
use PHPUnit\Framework\TestCase;
use Prophecy\Prophecy\ProphecyInterface;
use Psr\Container\ContainerInterface;
use ReflectionProperty;
use Zend\Expressive\Helper\ServerUrlHelper;
use Zend\Expressive\Helper\UrlHelper;
use Zend\Expressive\Plates\Extension\EscaperExtension;
use Zend\Expressive\Plates\Extension\UrlExtension;
use Zend\Expressive\Plates\PlatesRendererFactory;
use Zend\Expressive\Plates\PlatesRenderer;
use Zend\Expressive\Plates\PlatesRendererFactory;
use Zend\Expressive\Template\TemplatePath;

use function restore_error_handler;
use function set_error_handler;
use function sprintf;

use const E_USER_WARNING;

class PlatesRendererFactoryTest extends TestCase
{
/**
Expand Down
14 changes: 13 additions & 1 deletion test/PlatesRendererTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,22 @@
use ArrayObject;
use League\Plates\Engine;
use PHPUnit\Framework\TestCase;
use Zend\Expressive\Template\Exception;
use Zend\Expressive\Plates\PlatesRenderer;
use Zend\Expressive\Template\Exception;
use Zend\Expressive\Template\TemplatePath;

use function array_shift;
use function file_get_contents;
use function restore_error_handler;
use function set_error_handler;
use function sprintf;
use function str_replace;
use function uniqid;
use function var_export;

use const E_NOTICE;
use const E_USER_WARNING;

class PlatesRendererTest extends TestCase
{
/**
Expand Down

0 comments on commit 679f00e

Please sign in to comment.