This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Made UrlExtension not to be registered if either one of the helpers is not registered #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geerteltink
approved these changes
Oct 13, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
Made UrlExtension not to be registered if either one of the helpers is not registered
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
|
Thanks, @acelaya |
|
You are welcome :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #24
I have made the
UrlExtensionnot to be loaded on plates engine when either theUrlHelperor theServerUrlHelperare not registered in the container.This way, if you don't need them, you don't have to depend on the zendframework/zend-expressive-helpers package.
I have selected an approach in which the check is not performed if you have explicitly registered the
UrlExtensionin the container. In that case, an exception will still be thrown if you didn't register the helpers yourself.