This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Provide a URL/ServerUrl extension, and extension loading #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch was prompted by a desire to have `url` and `serverurl` functions that proxy to the zend-expressive-helpers classes. In order to do that, however, I ended up needing the following as well: - The ability to register the `League\Plates\Engine` as a service, and consume it when present. - A factory for `League\Plates\Engine` that can load extensions into the engine (via instance, service name, or class name), as well as load the custom URL extension by default. - The UrlExtension itself, which composes UrlHelper and ServerUrlHelper instances. - A factory for the UrlExtension that raises exceptions if either helper is missing. I updated the PlatesRendererFactory to delegate to the new PlatesEngineFactory if no `League\Plates\Engine` service is present in order to create the Plates engine instance. This also then ensures that by default, we have the `UrlExtension` loaded.
|
I have no idea why this isn't triggering a build. 😬 |
|
I've tested this in a skeleton application, updating hard-coded URIs to use the |
|
Why is this not merged yet ? |
|
@ricardofiorani Was hoping for folks to test it and provide feedback. |
| // Create the engine instance: | ||
| $engine = new PlatesEngine(); | ||
|
|
||
| $this->injectUrlExtension($container, $engine); |
There was a problem hiding this comment.
In here, instead of hardcoded inject the UrlExtesion, we could allow more extensions to be provided via config, like:
'templates' => [
'extension' => 'phtml',
'paths' => [
'app' => ['templates/app'],
'layout' => ['templates/layout'],
'error' => ['templates/error'],
],
'extensions' => [
Extension\UrlExtension::class => Zend\Expressive\Plates\Extension\UrlExtensionFactory::class
],
]There was a problem hiding this comment.
@ricardofiorani That can be done with delegator factories, or by providing your own factory.
There was a problem hiding this comment.
@ricardofiorani Actually, I was wrong: functionality is already present in the PlatesEngineFactory. 😄
mwillbanks
added a commit
that referenced
this pull request
Mar 29, 2016
Provide a URL/ServerUrl extension, and extension loading
mwillbanks
added a commit
that referenced
this pull request
Mar 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch was prompted by a desire to have
urlandserverurlfunctions that proxy to the zend-expressive-helpers classes. In order to do that, however, I ended up needing the following as well:League\Plates\Engineas a service, and consume it when present.League\Plates\Enginethat can load extensions into the engine (via instance, service name, or class name), as well as load the custom URL extension by default.I updated the PlatesRendererFactory to delegate to the new PlatesEngineFactory if no
League\Plates\Engineservice is present in order to create the Plates engine instance. This also then ensures that by default, we have theUrlExtensionloaded.Because this patch provides extension loading, it supercedes the one in #6, and fixes #3.