Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Move middleware into subnamespace #54

Conversation

weierophinney
Copy link
Member

Per the migration roadmap, all middleware shipped by this component need to be in a subnamespace, as that's where they will be in version 3.

This patch moves the route and dispatch middleware to the Zend\Expressive\Router\Middleware namespace, and then creates extensions under the original names that are immediately deprecated.

weierophinney added a commit to weierophinney/zend-expressive-router that referenced this pull request Mar 1, 2018
@weierophinney weierophinney added this to the 2.4.0 milestone Mar 1, 2018
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Per the [migration roadmap](https://discourse.zendframework.com/t/roadmap-expressive-2-2/504),
all middleware shipped by this component need to be in a subnamespace,
as that's where they will be in version 3.

This patch moves the route and dispatch middleware to the
`Zend\Expressive\Router\Middleware` namespace, and then creates
extensions under the original names that are immediately deprecated.
@weierophinney weierophinney merged commit 194b2fe into zendframework:develop Mar 6, 2018
weierophinney added a commit that referenced this pull request Mar 6, 2018
@weierophinney weierophinney deleted the feature/middleware-namespace branch March 6, 2018 14:10
weierophinney added a commit that referenced this pull request Mar 8, 2018
Forward port #54
Forward port #55
Forward port #57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants