fix remaining cookie lifetime test cases

zendframework · Feb 28, 2019 · 5ebdb3c · 5ebdb3c
1 parent 42d964b
commit 5ebdb3c
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/test/PhpSessionPersistenceTest.php b/test/PhpSessionPersistenceTest.php
@@ -501,7 +501,6 @@ public function testCookiesSetWithDefaultLifetime()
     public function testCookiesSetWithCustomLifetime()
     {
         $lifetime = 300;
-        $expectedTimestamp = time() + $lifetime;
 
         $ini = $this->applyCustomSessionOptions([
             'cookie_lifetime' => $lifetime,
@@ -513,11 +512,17 @@ public function testCookiesSetWithCustomLifetime()
 
         $session->set('foo', 'bar');
 
+        $expiresMin = time() + $lifetime;
         $response = $persistence->persistSession($session, new Response());
+        $expiresMax = time() + $lifetime;
 
         $setCookie = FigResponseCookies::get($response, session_name());
         $this->assertInstanceOf(SetCookie::class, $setCookie);
-        $this->assertSame($expectedTimestamp, $setCookie->getExpires());
+
+        $expires = $setCookie->getExpires();
+
+        $this->assertGreaterThanOrEqual($expiresMin, $expires);
+        $this->assertLessThanOrEqual($expiresMax, $expires);
 
         $this->restoreOriginalSessionIniSettings($ini);
     }
@@ -533,11 +538,17 @@ public function testAllowsSessionToSpecifyLifetime()
         $lifetime = 300;
         $session->persistSessionFor($lifetime);
 
+        $expiresMin = time() + $lifetime;
         $response = $persistence->persistSession($session, new Response());
+        $expiresMax = time() + $lifetime;
 
         $setCookie = FigResponseCookies::get($response, session_name());
         $this->assertInstanceOf(SetCookie::class, $setCookie);
-        $this->assertSame(time() + $lifetime, $setCookie->getExpires());
+
+        $expires = $setCookie->getExpires();
+
+        $this->assertGreaterThanOrEqual($expiresMin, $expires);
+        $this->assertLessThanOrEqual($expiresMax, $expires);
 
         // reset lifetime
         session_set_cookie_params($originalLifetime);