This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
refactor test cases #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: 1. modify the `createSessionCookieRequest` helper method signature by using `sessionId` as first argument it being the most commonly varying parameter 2. update 3 older test cases to use the above mentioned helper method 3. swap arguments in assertions to have the expected value as first argument 4. as a side effect of point 3, fix assertions regarding expire headers valure range (failure only appearing when adding delaying function calls) 5. add inline commentary
weierophinney
added a commit
that referenced
this pull request
May 14, 2018
|
Thanks, @pine3ree! Really nice work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list of changes:
createSessionCookieRequesthelper method signature by usingsessionIdas first argument it being the most commonly varying parameter