Isolate session on disk between test cases

[PowerKiKi]

This prevent side-effects between test cases via session that might
or might not pre-exist on disk.

As discussed in #44 (comment). Once that other PR is merged, I'll rebase this one to remove that time() usage that won't be necessary anymore.

Do test improvements also require a CHANGELOG entry ?

Provide a narrative description of what you are trying to accomplish:

• Are you fixing a bug?

  • Detail how the bug is invoked currently.
  • Detail the original, incorrect behavior.
  • Detail the new, expected behavior.
  • Base your feature on the master branch, and submit against that branch.
  • Add a regression test that demonstrates the bug, and proves the fix.
  • Add a CHANGELOG.md entry for the fix.

• Are you creating a new feature?

  • Why is the new feature needed? What purpose does it serve?
  • How will users use the new feature?
  • Base your feature on the develop branch, and submit against that branch.
  • Add only one feature per pull request; split multiple features over multiple pull requests
  • Add tests for the new feature.
  • Add documentation for the new feature.
  • Add a CHANGELOG.md entry for the new feature.

• Is this related to quality assurance?

• Is this related to documentation?

[weierophinney]

I've rebased for you; pull and update your local checkout.

I've indicated one change we need, which you'll see in comments below.

You also mentioned removing some time() usage, but I wasn't exactly sure which, so I'll have you go ahead and complete this before I merge.

As this is a QA improvement, we can merge at any time. I have some pending updates that need to be released, so I'll go ahead and do those; ping me when the tests are ready to merge.

Thanks!

[weierophinney]

This should happen in tearDown(), to ensure we leave things clean on completion.

[PowerKiKi]

@weierophinney, I fixed what you suggested, and removed the time() thing I was talking about. I made a separate commit so it's easier to review. But I'll squash everything if you let me know.

[weierophinney]

This repository has been closed and moved to mezzio/mezzio-session-ext; a new issue has been opened at mezzio/mezzio-session-ext#2.

[weierophinney]

This repository has been moved to mezzio/mezzio-session-ext. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

• Squash all commits in your branch (git rebase -i origin/{branch})
• Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
• Run the laminas/laminas-migration tool on the code.
• Clone mezzio/mezzio-session-ext to another directory.
• Copy the files from the second bullet point to the clone of mezzio/mezzio-session-ext.
• In your clone of mezzio/mezzio-session-ext, commit the files, push to your fork, and open the new PR.
  We will be providing tooling via laminas/laminas-migration soon to help automate the process.