Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Refactor and improve tests #109

Merged
merged 26 commits into from Sep 1, 2016
Merged

Refactor and improve tests #109

merged 26 commits into from Sep 1, 2016

Conversation

geerteltink
Copy link
Member

@geerteltink geerteltink commented Aug 27, 2016 •
edited

This PR is based on #101

  • Parse composer package and populate definitions and requirements
  • Add test for cleaning up the de requirements
  • Remove installPackage method from the test case and use the function from the installer
  • Test 'n' answers
  • Test answers with custom packages
  • Update travis file
  • Drop php 5.5
  • Add coveralls support
  • Improve coverage

@geerteltink geerteltink changed the title [WIP] Refactor and improve tests Refactor and improve tests Aug 29, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7e7ba63 on xtreamwayz:feature/improve-tests into * on zendframework:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 964e64a on xtreamwayz:feature/improve-tests into * on zendframework:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 132cce2 on xtreamwayz:feature/improve-tests into * on zendframework:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2b2b10d on xtreamwayz:feature/improve-tests into * on zendframework:master*.

weierophinney
weierophinney reviewed Sep 1, 2016
View reviewed changes
.travis.yml
matrix:
fast_finish: true
include:
- php: 5.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this for master, we need to keep 5.5 in here; if we do it for develop, and the 1.1 release, we can leave as-is. I'm going to leave it to you, @xtreamwayz , to decide which you want to target.

@weierophinney
Copy link
Member

Awesome work, @xtreamwayz !

One note: can you please rebase? I merged a few patches from you earlier today that affect the changes you've done (notably: ocramius/proxy-manager removal from $devDependencies, and the looping for the "minimal install" prompt).

Thanks!

@geerteltink
Add error handler test
b81fd41
@geerteltink
Refactor test case and populate the installer from the parsed compose…
6e124bd 
…r package
@geerteltink
Remove unused response property
067f755
@geerteltink
Refactor dev dependencies removal and add a test
375088e
@geerteltink
Test all packages in one go
f6db55a
@geerteltink
The answer should be saved after the question is processed
b3d997f 
If this is saved before the packages are added and the files are copied, it won't ask the question again in case the installer failed during that process.
@geerteltink
Refactor removing installer from composer and add a test
ed1aba1
@geerteltink
Add missing docblock
0197fa2
@geerteltink
Add testing different types of answers
04f6490
@geerteltink
Remove install package method from the test case
62b7154
@geerteltink
Update Travis CI config and enable Coveralls
35721d4
@geerteltink
Remove coveralls src_dir from config
e6f9088
@geerteltink
Use the correct coverall badge and url
31b3d54
@geerteltink
Use the correct travis globals please :D
65ccd5f
@geerteltink
Exclude the installer resources for coverage
38acc3b
@geerteltink
Don't process uncovered files from whitelist
3b85069
@geerteltink
Properly exclude the resources directory
311101d
@geerteltink
Exclude some parts which can't be tested without modifying source files
ae10a75
@geerteltink
Skip locked dependency tests since there is no composer.lock file inc…
4e329d7 
…luded
@geerteltink
Send travis notifications to irc and disable email notifications
c38c5ba
@geerteltink
The scripts section in composer.json is never empty so it doesn't nee…
d270c0b 
…d to be removed
@geerteltink
Remove branch-alias
7b96d1f
@geerteltink
Copy link
Member Author

@weierophinney Rebase done.

@weierophinney weierophinney added this to the 1.0.3 milestone Sep 1, 2016
@weierophinney weierophinney self-assigned this Sep 1, 2016
weierophinney
weierophinney reviewed Sep 1, 2016
View reviewed changes
test/ExpressiveInstallerTest/InstallerTestCase.php
@@ -24,79 +26,111 @@
class InstallerTestCase extends \PHPUnit_Framework_TestCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to mark this as abstract when I merge, as the intention is for test cases to extend it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can rename it to AbstractInstallerTestCase as well.

@weierophinney weierophinney merged commit 071291d into zendframework:master Sep 1, 2016
weierophinney added a commit that referenced this pull request Sep 1, 2016
@weierophinney
Merge pull request #109 from xtreamwayz/feature/improve-tests
4ea0eba 
Refactor and improve tests
weierophinney added a commit that referenced this pull request Sep 1, 2016
@weierophinney
Added CHANGELOG for #109
9e47230
weierophinney added a commit that referenced this pull request Sep 1, 2016
@weierophinney
Merge branch 'hotfix/109'
c928c8f 
Close #109
weierophinney added a commit that referenced this pull request Sep 1, 2016
@weierophinney
Merge branch 'hotfix/109' into develop
109c59f 
Forward port #109

Conflicts:
	CHANGELOG.md
@geerteltink geerteltink deleted the feature/improve-tests branch September 3, 2016 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@weierophinney weierophinney

Labels
enhancement
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geerteltink @coveralls @weierophinney