Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Updated symfony/console required version to be less restrictive #25

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Updated symfony/console required version to be less restrictive #25

merged 1 commit into from
Apr 28, 2017

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Apr 15, 2017

I have tested that all commands keep working with symfony/console 2.8, 3.0 and 3.1, as well as 3.2, so I have changed the required version to ^3.0 || ^2.8.

I think this is important, since symfony/console is a widely used component, and being too restrictive could cause version conflicts.

Also, symfony 3.3 is going to be released soon, and requiring ^3.2.7 will conflict with users that want to use it.

I haven't added tests because of the way travis is configured. As far as I see, tests are already being run against different dependency versions and passing.

@geerteltink
Copy link
Member

geerteltink commented Apr 15, 2017

Also, symfony 3.3 is going to be released soon, and requiring ^3.2.7 will conflict with users that want to use it.

I think you are confusing ^3.2.7 with ~3.2.7.

caret: ^3.2.7 is equivalent to >=3.2.7 <4.0.0
tilde: ~3.2.7 is equivalent to >=3.2.7 <3.3.0

@acelaya
Copy link
Contributor Author

acelaya commented Apr 15, 2017

Right, my mistake.
Anyway, I don't see any reason to not support earlier compatible versions

@geerteltink geerteltink added this to the 0.4.3 milestone Apr 28, 2017
@geerteltink geerteltink merged commit efe2c59 into zendframework:master Apr 28, 2017
geerteltink added a commit that referenced this pull request Apr 28, 2017
geerteltink added a commit that referenced this pull request Apr 28, 2017
@geerteltink
Copy link
Member

Thanx @acelaya

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants