Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Migrate interop middlewares tool updated to final PSR-15 #44

Merged
merged 4 commits into from
Feb 6, 2018
Merged

Migrate interop middlewares tool updated to final PSR-15 #44

merged 4 commits into from
Feb 6, 2018

Conversation

michalbundyra
Copy link
Member

It migrates now all kind of interop middlewares

It migrates now all kind of interop middlewares
Copy link
Member

@geerteltink geerteltink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix import order in all test classes and change the date range :D

@michalbundyra
Copy link
Member Author

@xtreamwayz it will be very hard to change order of imports there - please note these are TestAssets, and the tool is replacing interfaces with proper PSR-15 interfaces.

About date range... Yeh... I can update it, but I would prefer to remove these headers and year from header at all then updating it every year. Hopefully we will have soon zend-coding-standard in place and we can get rid of these headers for ever!

weierophinney added a commit to weierophinney/zend-expressive-tooling that referenced this pull request Feb 6, 2018
Migrate interop middlewares tool updated to final PSR-15
@weierophinney weierophinney merged commit 117d959 into zendframework:release-1.0.0 Feb 6, 2018
weierophinney added a commit that referenced this pull request Feb 6, 2018
weierophinney added a commit that referenced this pull request Feb 6, 2018
@weierophinney
Copy link
Member

Thanks, @webimpress!

@michalbundyra michalbundyra deleted the psr-15 branch February 6, 2018 22:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants