This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Added new command migrate:middleware-to-request-handler #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert PSR-15 middleware to request handler in given path. It should be used to convert final middlewres binded to routes which are not using delegator/request handler. Works only with PSR-15 middlewares (if you have interop middlewares migrate them first to PSR-15 middlewares by migrate:interop-middleware and then convert them to request handlers).
|
I would argue that this should raise an exception if it detects any |
I'll try to add this check. I need to find what is the variable name and then look for |
When we detect `$handler->handle(` phrase (where variable `$handler` can be different and it's get from `process` method signature) we are not going to do any changes in the file.
weierophinney
suggested changes
Feb 19, 2018
| @@ -0,0 +1,21 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
We need a license docblock here and on the other test asset; we should likely also add the declare(strict_types=1), though that's not completely necessary.
weierophinney
added a commit
that referenced
this pull request
Feb 21, 2018
weierophinney
added a commit
that referenced
this pull request
Feb 21, 2018
|
Thanks, @webimpress! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert PSR-15 middleware to request handler in given path. It should be used to convert final middlewres binded to routes which are not using delegator/request handler.
Works only with PSR-15 middlewares (if you have interop middlewares migrate them first to PSR-15 middlewares by migrate:interop-middleware and then convert them to request handlers).