Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Removed version constant with console application #62

Closed
wants to merge 1 commit into from
Closed

Removed version constant with console application #62

wants to merge 1 commit into from

Conversation

michalbundyra
Copy link
Member

Provide a narrative description of what you are trying to accomplish:

@michalbundyra michalbundyra changed the title Remvoed version constant with console application Removed version constant with console application Feb 15, 2018
It is not required and it will only causes issues on releasing new version
@weierophinney
Copy link
Member

Why? This is something we should be doing when tagging. Having the version helps users easily identify which version they are running, without needing to resort to using composer.

@michalbundyra
Copy link
Member Author

@weierophinney we tried to have it in ZendApplicationSkeleton and it doesn't work. Always on release someone forgot to bump this version, and in that package is even easier to ask just for installed package list what will be always accurate.

@weierophinney
Copy link
Member

@webimpress That's a completely different situation; in that case, we were trying to detail a "framework" or "skeleton" version. In this case, we're detailing the version of the tool, which is something we absolutely know.

If you're worried about automation, we can look into webhooks, git hooks, or something like ocramius/package-versions. But this is one place I think having a version makes sense.

@michalbundyra
Copy link
Member Author

@weierophinney It's your final decision, I think it's common to ask just for composer show results, it gives us more information than just the tool version.

If we are going to keep the version definitely we should have something what will help us to remember about updating that version on release.

@weierophinney
Copy link
Member

While composer show is reasonable for us, I've worked with enough users to know that this is not true of everyone.

I looked into ways to resolve this, and the only one I can think of would be if we could install an update git hook for the repo... which, with GitHub, just isn't possible.

Another possibility is to use a pre-commit hook that calls the current bin/bump-version script with the results of git describe for the version. The issue with this is that the only time that returns a tag name... is if you have checked out the tag. Additionally, it requires any maintainers to make sure they install the hook in their local checkout.

I'll keep thinking on this. For now, though, I'm rejecting the patch, as this is a feature I'd like us to keep; we just need to figure out a more fool-proof way of ensuring it's updated.

@geerteltink
Copy link
Member

ocramius/package-versions is built for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants