This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Default params now passed to child models. Fixes #57. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2018
Also sets date for 2.0.1 release.
weierophinney
added a commit
that referenced
this pull request
Aug 13, 2018
Forward port #58 Conflicts: CHANGELOG.md
|
Thanks, @samuelnogueira! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass default parameters to child view models:
Are you fixing a bug?
Detailed in Default parameters not passed to child view models #57
Detailed in Default parameters not passed to child view models #57
Default parameters for the child template and all templates are passed to child view model
See
\ZendTest\Expressive\ZendView\ZendViewRendererTest::testRenderChildWithDefaultParameterCHANGELOG.mdentry for the fix.(should I?)
Is this related to quality assurance?
I think not.
Is this related to documentation?
No.