Fixed missing root using layout viewhelper #62
Conversation
src/ZendViewRenderer.php
Outdated
| @@ -269,6 +269,11 @@ private function injectNamespacedResolver(AggregateResolver $aggregate) : void | |||
| $aggregate->attach(new NamespacedPathStackResolver(), 0); | |||
| } | |||
|
|
|||
| /** | |||
| * @param AggregateResolver $aggregate | |||
There was a problem hiding this comment.
Please undo all these changes as they are not needed. The method declaration already contains this information!
Additionally the topic of this PR the fix #68 rather than adding more DocBlocks or clean up anything.
That also makes the review easier. Thanks!
There was a problem hiding this comment.
Sorry, I reverted the cleanup.
|
Everything should be clean now. Please let me know if it is ok. We need this fix for a deployment. Thanks in advance. |
Then use your own fork in the meantime: https://getcomposer.org/doc/04-schema.md#repositories |
|
ok, we can use this for workaround now. But just out of curiosity: How long does such a review take? |
Depends on the PR. I don't use zend-view myself so I won't merge this as I have no clue what it does and if this would be a good solution. You would have to wait for someone else and since it's Friday it will probably be early next week. |
src/ZendViewRenderer.php
Outdated
| $result = $this->renderModel($child, $renderer); | ||
|
|
||
| if ($child !== $root) { | ||
| $viewModelHelper = $renderer->plugin('view_model'); |
There was a problem hiding this comment.
Shouldn't this be $renderer->plugin(ViewModel::class); where ViewModel is aliased to \Zend\View\Helper\ViewModel. At some point, all those old string aliases will go away won't they?
There was a problem hiding this comment.
That ist not correct. The ViewHelper is called 'view_model'. It is not using the container here, but the HelperPluginManager. You could call it with $renderer->view_model() also. But I prefer to call it this way. That's the way Zend/View does it internally.
Here is the code in PhpRenderer:
// Give view model awareness via ViewModel helper
$helper = $this->plugin('view_model');
$helper->setCurrent($model);
Or in Layout helper:
protected function getViewModelHelper()
{
if (null === $this->viewModelHelper) {
$this->viewModelHelper = $this->getView()->plugin('view_model');
}
return $this->viewModelHelper;
}
There was a problem hiding this comment.
That ist not correct.
Please compare with:
And the aliases:
It is not using the container here, but the HelperPluginManager.
A plugin-manager is a service-manager / container:
https://docs.zendframework.com/zend-servicemanager/plugin-managers/
There was a problem hiding this comment.
Oh I see. I tried to use the class, but it does not work.
Perhaps we need to pump up the dependency of zend view to a higher version.
I have to investigaste it further.
And you are right. The HelperPluginManager is a Container. My bad.
There was a problem hiding this comment.
I use the class now. It is working now. I did import the worng class initially. Thanks for correcting me. This is much better.
Fixed missing root using layout viewhelper
Forward port #62 Conflicts: CHANGELOG.md
|
Thanks, @fduarte42! |
Fixed bug mentioned here:
zendframework/zend-expressive-skeleton#68