Hotfix/docs getting started #631
Conversation
| ```php | ||
| <h1>Hello <?= $this->target ?></h1> | ||
| ``` | ||
| ```html |
There was a problem hiding this comment.
PHP was correct, because the interesting part of this code sample is PHP and not HTML.
There was a problem hiding this comment.
Changed it to php but that doesn't seem to render nice when previewing the markdown file.
There was a problem hiding this comment.
Well, the target is mkdocs, so not really an issue. :)
|
|
||
| ```php | ||
| <h1>Hello <?= $this->target ?></h1> | ||
| ``` | ||
| // plates |
There was a problem hiding this comment.
Sorry, a misunderstanding. The code example is HTML and PHP (PHTML), but the relevant part is PHP. Therefore we use "php" in the documentation for this kind of code examples. It would be better if we can use "php+html", but I don't know if this work.
So please revert to HTML comment syntax.
There was a problem hiding this comment.
Reverted back to html.
There was a problem hiding this comment.
@xtreamwayz
I found this:
There has to be at least one tag in the source code, for Prism to detect if it is a HTML page with PHP tags included or simple plain PHP code.
|
Thanks, @xtreamwayz! |
Provide a narrative description of what you are trying to accomplish:
During the conversion of v2 to v3 docs the quick start text for creating a hello template was changed in such way that it unclear what code to use for which renderer. This PR adds example code for plates, zend-view and twig.