This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Do not cast request handlers implementing middleware to RequestHandlerMiddleware
#646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erMiddleware` Per zendframework#645, `MiddlewareContainer::get()` was incorrectly casting middleware that also implemented `RequestHandlerInterface` to `RequestHandlerMiddleware`. This particularly affected `Zend\Stratigility\MiddlewarePipe` instances, as they implement both interfaces; if the last middleware in a pipeline called on the handler, users would then encounter a "pipeline exhausted" error, because it would be invoked as a handler, and thus have no reference to the application's pipeline. This change verifies that the request handler does not also implement `MiddlewareInterface` before casting.
weierophinney
added a commit
that referenced
this pull request
Nov 8, 2018
weierophinney
added a commit
that referenced
this pull request
Nov 8, 2018
Forward port #646 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #645,
MiddlewareContainer::get()was incorrectly casting middleware that also implementedRequestHandlerInterfacetoRequestHandlerMiddleware. This particularly affectedZend\Stratigility\MiddlewarePipeinstances, as they implement both interfaces; if the last middleware in a pipeline called on the handler, users would then encounter a "pipeline exhausted" error, because it would be invoked as a handler, and thus have no reference to the application's pipeline.This change verifies that the request handler does not also implement
MiddlewareInterfacebefore casting.Fixes #645