Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Update pubsubhubbub.md #108

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

cotton-more
Copy link
Contributor

Fix code example of creating a \Zend\Feed\PubSubHubbub\Publisher - add a new keyword.

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?

    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.
  • Are you creating a new feature?

    • Why is the new feature needed? What purpose does it serve?
    • How will users use the new feature?
    • Base your feature on the develop branch, and submit against that branch.
    • Add only one feature per pull request; split multiple features over multiple pull requests
    • Add tests for the new feature.
    • Add documentation for the new feature.
    • Add a CHANGELOG.md entry for the new feature.
  • Is this related to quality assurance?

  • Is this related to documentation?
    Fix a typo when creating an instance of a \Zend\Feed\PubSubHubbub\Publisher class.

Fix code example of creating a \Zend\Feed\PubSubHubbub\Publisher - add a `new` keyword.
@michalbundyra
Copy link
Member

Thanks, @vansanblch!

2 similar comments
@michalbundyra
Copy link
Member

Thanks, @vansanblch!

@michalbundyra
Copy link
Member

Thanks, @vansanblch!

michalbundyra added a commit that referenced this pull request Oct 15, 2019
michalbundyra added a commit that referenced this pull request Oct 15, 2019
@michalbundyra michalbundyra merged commit 1e3da29 into zendframework:master Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants