This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Enable Reader online tests #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of this tests could be refactored as unit tests. |
| @@ -158,7 +158,7 @@ public function testImportsUriAndThrowsExceptionIfNotAFeed() | |||
| $this->markTestSkipped('testImportsUri() requires a network connection'); | |||
| } | |||
|
|
|||
| Reader\Reader::import('http://twitter.com/alganet'); | |||
| Reader\Reader::import('http://example.com'); | |||
There was a problem hiding this comment.
Why the change in URL? When I ran these tests last week, the original URLs worked correctly for the test expectations...
There was a problem hiding this comment.
Troubles with redirect to HTTPS protocol. I didn't want to deal with that https://travis-ci.org/zendframework/zend-feed/jobs/92411760#L317
|
Rest of changes was done because the source of the reference webpages has changed. In the future this tests should be refactored with a mock of the http client. |
weierophinney
added a commit
that referenced
this pull request
Nov 24, 2015
Enable Reader online tests
weierophinney
added a commit
that referenced
this pull request
Nov 24, 2015
|
Merged to develop for release with 2.6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.