Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Enhancement: Raise minimum PHP version to PHP 7.1 #39

Merged
merged 2 commits into from
Apr 25, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Apr 21, 2017

This PR

  • raises the minimum PHP version from PHP 5.5 to PHP 7.1
  • updates phpunit/phpunit
  • ...

πŸ’β€β™‚οΈ For reference, see http://tinyletter.com/mwopzend/letters/zend-framework-community-news-for-the-week-of-2017-04-20.

@froschdesign
Copy link
Member

@localheinz
Develop branch!

@localheinz
Copy link
Member Author

Ha, thank you, @froschdesign! Will take a look later!

@localheinz
Copy link
Member Author

@froschdesign @weierophinney

What do you think, should we also use

  • strict types
  • scalar type hints
  • return type declarations

?

@froschdesign
Copy link
Member

@localheinz

  • strict types
  • scalar type hints
  • return type declarations
  • Void return types
  • Nullable types
  • "iterable" pseudo-type
  • …

All features which simplify the code and make the interfaces more clear.


Btw. HHVM makes no sense if we allow failures on Travis.

@localheinz localheinz mentioned this pull request May 31, 2017
1 task
@weierophinney
Copy link
Member

This is a great start. However, per your question:

What do you think, should we also use

strict types
scalar type hints
return type declarations

The answer is yes. Adopting PHP 7.1 as the new minimum version should really only happen if we are going to make use of those features, particularly as they affect consumers (extending classes or implementing interfaces means changes when we add these type hints).

I'll be merging #43 shortly, and issuing a new release when done. After that, rebase this based on the new status of develop, and let's see how far you can take it!

@weierophinney weierophinney merged commit 7c1e85a into zendframework:develop Apr 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants