Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Commit

Permalink
Merge branch 'remove-tests-catch-fail' of https://github.com/Maks3w/zf2
Browse files Browse the repository at this point in the history
… into hotfix/tests-exceptions
  • Loading branch information
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 14 deletions.
8 changes: 3 additions & 5 deletions test/Client/StaticTest.php
Expand Up @@ -484,11 +484,9 @@ public function testOpenTempStreamWithValidFileDoesntThrowsException()
'outputstream' => realpath(__DIR__ . '/_files/zend_http_client_stream.file'),
);
$client = new HTTPClient($url, $config);
try {
$result = $client->send();
} catch (Http\Exception\ExceptionInterface $e) {
$this->fail('Unexpected exception was thrown: ' . $e->getMessage() . "\n" . $e->getTraceAsString());
}

$result = $client->send();

// we can safely return until we can verify link is still active
// @todo verify link is still active
return;
Expand Down
13 changes: 4 additions & 9 deletions test/ClientTest.php
Expand Up @@ -17,15 +17,10 @@ public function testClientRetrievesUppercaseHttpMethodFromRequestObject()

public function testIfZeroValueCookiesCanBeSet()
{
try {
$client = new Client();
$client->addCookie("test", 0);
$client->addCookie("test2", "0");
$client->addCookie("test3", false);
} catch (Exception\InvalidArgumentException $e) {
$this->fail('Zero Values should be valid');
}
$this->assertTrue(true);
$client = new Client();
$client->addCookie("test", 0);
$client->addCookie("test2", "0");
$client->addCookie("test3", false);
}

/**
Expand Down

0 comments on commit 1d20fd1

Please sign in to comment.