Fix invalid exception from urlencoded cookie value

Fix #15
zendframework · Sep 12, 2015 · 83bcfc1 · 83bcfc1
1 parent 665a976
commit 83bcfc1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Header/SetCookie.php b/src/Header/SetCookie.php
@@ -302,7 +302,6 @@ public function getName()
      */
     public function setValue($value)
     {
-        HeaderValue::assertValid($value);
         $this->value = $value;
         return $this;
     }

diff --git a/test/Header/SetCookieTest.php b/test/Header/SetCookieTest.php
@@ -9,6 +9,7 @@
 
 namespace ZendTest\Http\Header;
 
+use Zend\Http\Header\HeaderValue;
 use Zend\Http\Header\SetCookie;
 
 class SetCookieTest extends \PHPUnit_Framework_TestCase
@@ -431,8 +432,8 @@ public function testPreventsCRLFAttackViaFromString()
      */
     public function testPreventsCRLFAttackViaConstructor()
     {
-        $this->setExpectedException('Zend\Http\Header\Exception\InvalidArgumentException');
         $header = new SetCookie("leo_auth_token", "example\r\n\r\nevilContent");
+        $this->assertTrue(HeaderValue::isValid($header->getFieldValue()));
     }
 
     public function setterInjections()