This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Trigger user deprecated error on deprecated classes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in previous test instead assertInternalType we are using assertIsString. Method `assertInternalType` is deprecated since PHPUnit 7.5.
We go back and forth on whether or not to include these; a lot of folks complain when they see them, but we also get a fair number of folks happy to get provided the information they need for migration. I mainly didn't do it because testing these is always such a pain, and we then have to remove the tests in the next version; I was being lazy. 😄 I've rebased off of current develop, and referenced this patch in the CHANGELOG section indicating deprecations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should help with migrations. Not sure why it was not added here, maybe there is some reasoning not to adding it?