Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Test failure #97

Closed
remicollet opened this issue May 23, 2018 · 2 comments
Closed

Test failure #97

remicollet opened this issue May 23, 2018 · 2 comments

Comments

@remicollet
Copy link
Contributor

remicollet commented May 23, 2018

From Fedora QA
https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-i18n

Running 2.8.0 or 2.9.0 test suite:

There were 6 failures:
1) ZendTest\I18n\View\Helper\NumberFormatTest::testBasic with data set #4 ('de_DE', 4, 3, null, array(), 1234567.8912345679, '1,23456789123457E6')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1,23456789123457E6'
+'1,2345678912345679E6'
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:222
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:187
2) ZendTest\I18n\View\Helper\NumberFormatTest::testBasic with data set #7 ('ru_RU', 4, 3, null, array(), 1234567.8912345679, '1,23456789123457E6')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1,23456789123457E6'
+'1,2345678912345679E6'
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:222
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:187
3) ZendTest\I18n\View\Helper\NumberFormatTest::testBasic with data set #10 ('en_US', 4, 3, null, array(), 1234567.8912345679, '1.23456789123457E6')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1.23456789123457E6'
+'1.2345678912345679E6'
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:222
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:187
4) ZendTest\I18n\View\Helper\NumberFormatTest::testSettersProvideDefaults with data set #4 ('de_DE', 4, 3, null, array(), 1234567.8912345679, '1,23456789123457E6')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1,23456789123457E6'
+'1,2345678912345679E6'
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:222
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:210
5) ZendTest\I18n\View\Helper\NumberFormatTest::testSettersProvideDefaults with data set #7 ('ru_RU', 4, 3, null, array(), 1234567.8912345679, '1,23456789123457E6')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1,23456789123457E6'
+'1,2345678912345679E6'
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:222
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:210
6) ZendTest\I18n\View\Helper\NumberFormatTest::testSettersProvideDefaults with data set #10 ('en_US', 4, 3, null, array(), 1234567.8912345679, '1.23456789123457E6')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1.23456789123457E6'
+'1.2345678912345679E6'
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:222
/builddir/build/BUILD/zend-i18n-6d69af5a04e1a4de7250043cb1322f077a0cdb7f/test/View/Helper/NumberFormatTest.php:210

This seems related to libicu upgrade from 60.2 et 61.1

@weierophinney
Copy link
Member

If it's related to libicu... then what approach can we take, exactly?

Currently, our CI shows these working fine: https://travis-ci.org/zendframework/zend-i18n/branches

Are there values we can use that will work across libicu versions? Or would we need to vary values based on libicu version?

Right now, I have no idea how to approach this, particularly since I do not know how to reproduce it or prove it with our CI setup. Any guidance you can provide would be appreciated.

@remicollet
Copy link
Contributor Author

remicollet commented May 24, 2018

Travis is not a perfect tool... it run binaries nobody else use... and only on Intel x86_64...

BTW, test suite should be designed to test the project behavior not php or libraries used by PHP, so such test are very hard to write when they rely on PHP/library output.

See pr #99

weierophinney added a commit that referenced this issue May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants