Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Commit

Permalink
Removed shareByDefault() implementation
Browse files Browse the repository at this point in the history
From what I can tell, it was added for purposes of testing; I updated
the test to use `assertAttributeSame`, varying the property to test
against based on SM version.
  • Loading branch information
weierophinney committed Feb 18, 2016
1 parent 41c30e2 commit 598e20d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 0 additions & 5 deletions src/InputFilterPluginManager.php
Expand Up @@ -158,9 +158,4 @@ public function validatePlugin($plugin)
throw new Exception\RuntimeException($e->getMessage(), $e->getCode(), $e);
}
}

public function shareByDefault()
{
return $this->sharedByDefault;
}
}
6 changes: 5 additions & 1 deletion test/InputFilterPluginManagerTest.php
Expand Up @@ -52,7 +52,11 @@ public function testIsASubclassOfAbstractPluginManager()

public function testIsNotSharedByDefault()
{
$this->assertFalse($this->manager->shareByDefault());
$property = method_exists($this->manager, 'configure')
? 'sharedByDefault' // v3
: 'shareByDefault'; // v2

$this->assertAttributeSame(false, $property, $this->manager);
}

public function testRegisteringInvalidElementRaisesException()
Expand Down

0 comments on commit 598e20d

Please sign in to comment.