Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add PHP 7.2 support, drop HHVM #142

Merged
merged 5 commits into from
Nov 7, 2017
Merged

Conversation

Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented Jun 22, 2017

  • Cherry-pick fix for phpunit 6 #141
  • Adopt recent .travis.yml ZF standards (zend-session/.travis.yml picked)
  • Drop HVVM
  • Test PHP 7.2
  • Add partial PHP 7.2 support
    1. Fatal error: Declaration of Zend\InputFilter\CollectionInputFilter::isValid() must be compatible with Zend\InputFilter\BaseInputFilter::isValid($context = NULL) in /tmp/zend-inputfilter/src/CollectionInputFilter.php

Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@froschdesign
Copy link
Member

froschdesign commented Jun 22, 2017

The failing tests for the nightly build are related to Zend\Validator\EmailAddress and idn_to_ascii.

https://travis-ci.org/zendframework/zend-inputfilter/jobs/245787768#L381

@Slamdunk
Copy link
Contributor Author

@froschdesign thank you, zendframework/zend-validator#175

@Slamdunk
Copy link
Contributor Author

Note that
t
Because

"zendframework/zend-validator": "^2.6",

And zend-validator compatibility with PHP 7.2 was introduced only in zend-validator ^2.10 release

@michalbundyra
Copy link
Member

@Slamdunk Maybe then we should bump requirements in composer.json?

@Slamdunk
Copy link
Contributor Author

This is a decision that I cannot take, only maintainers know the path of expected components support.

@MatyCZ
Copy link

MatyCZ commented Oct 16, 2017

Any ETA for merging this PR?

@remicollet remicollet mentioned this pull request Oct 24, 2017
@froschdesign froschdesign added this to Ready in PHP 7.2 Oct 24, 2017
@froschdesign froschdesign added this to the 2.8.0 milestone Nov 7, 2017
@weierophinney
Copy link
Member

@MatyCZ I'm merging it today, but it won't release yet, as I have a PR or two I'm sitting on for the 2.8.0 release (primarily waiting for docs). This cannot release in a bugfix release, as it drops support for HHVM.

@weierophinney weierophinney merged commit 618c8f8 into zendframework:develop Nov 7, 2017
weierophinney added a commit that referenced this pull request Nov 7, 2017
Add PHP 7.2 support, drop HHVM
PHP 7.2 automation moved this from Ready to Finished Nov 7, 2017
weierophinney added a commit that referenced this pull request Nov 7, 2017
weierophinney added a commit that referenced this pull request Nov 7, 2017
@weierophinney
Copy link
Member

Thanks, @Slamdunk!

@Slamdunk Slamdunk deleted the php_72 branch December 1, 2017 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
PHP 7.2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants