This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Finalize zend-servicemanager forwards-compatibility changes #96
Merged
weierophinney
merged 10 commits into
zendframework:develop
from
weierophinney:feature/95
Feb 18, 2016
Merged
Finalize zend-servicemanager forwards-compatibility changes #96
weierophinney
merged 10 commits into
zendframework:develop
from
weierophinney:feature/95
Feb 18, 2016
Commits on Feb 13, 2016
-
3
Configuration menu - View commit details
-
Copy full SHA for 7756cc1 - Browse repository at this point
Copy the full SHA 7756cc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7796548 - Browse repository at this point
Copy the full SHA 7796548View commit details
Commits on Feb 17, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 310470c - Browse repository at this point
Copy the full SHA 310470cView commit details
Commits on Feb 18, 2016
-
Merge pull request zendframework#95 from kynx/sm-v2-v3-compat
ServiceManager v2-v3 compatibility
Configuration menu - View commit details
-
Copy full SHA for 368dae3 - Browse repository at this point
Copy the full SHA 368dae3View commit details -
Run a job per SM version per PHP version
- to ensure no regressions between PHP versions as well.
Configuration menu - View commit details
-
Copy full SHA for 86e6c2c - Browse repository at this point
Copy the full SHA 86e6c2cView commit details -
- ensure compat with both PHP 5.5+ and 7.0+ - Use `^2.6` (no maintenance version), as we don't need to get more specific at this time. - remove empty line at end of file
Configuration menu - View commit details
-
Copy full SHA for d26c4b4 - Browse repository at this point
Copy the full SHA d26c4b4View commit details -
Documented and simplified logic of populateFactoryPluginManagers
- Created a ternary from the original if/else, making the logic more compact. - Added the method docblock.
Configuration menu - View commit details
-
Copy full SHA for 656001c - Browse repository at this point
Copy the full SHA 656001cView commit details -
Incorporate feedback for InputFilterAbstractServiceFactory
- Move v2 checks into v2-specific methods of abstract factory. - Use provided `$services` argument when lazy-instantiating filter and validator plugin managers. - For abstract factory tests, vary methods tested based on service manager version.
Configuration menu - View commit details
-
Copy full SHA for ec011db - Browse repository at this point
Copy the full SHA ec011dbView commit details -
Ensure input filter plugin manager is BC with v2
- Renamed `MigrationTest` to `InputFilterPluginManagerCompatibilityTest` (consistency with other components, and this is specifically for testing migration of the plugin manager). - Added tests to validate that the `InputFilterPluginManager` accepts no arguments and/or a `ConfigInterface` argument to the constructor when using zend-servicemanager v2. - Updated the `InputFilterPluginManager` constructor to mirror that of the 2.7 and 3.0 series of zend-servicemanager; it also populates the initializers prior to calling the parent constructor, allowing overriding.
Configuration menu - View commit details
-
Copy full SHA for 41c30e2 - Browse repository at this point
Copy the full SHA 41c30e2View commit details -
Removed
shareByDefault()
implementationFrom what I can tell, it was added for purposes of testing; I updated the test to use `assertAttributeSame`, varying the property to test against based on SM version.
Configuration menu - View commit details
-
Copy full SHA for 598e20d - Browse repository at this point
Copy the full SHA 598e20dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.