This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
d98fa5b
commit 4db6018
Showing
4 changed files
with
2 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really wanted in 2.7.0 ?
ZF2 requires zend-servicemanager ^2.5
So this component (requiring 3.0.3) can't be installed.
Especially the commit message "CS" seems to enlight some unwanted change.
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is in require-dev I don't think this is the case. No? And that should not prevent from being installed I think. But maybe I am wrong not 100% sure about this. And yes commit message and diff seems a bit strange :D
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this doesn't prevent installation, at least prevent to run the test suite.
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry don't get it what test suite, because https://travis-ci.org/zendframework/zend-modulemanager runs just fine with both 3.0 and 2.7 versions. Also I think all the required packages already supports 3.0 it wouldn't be any difference if it was
^2.7.5 || ^3.0.3
or just^3.0.3
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encounter a:
I will dig more (probably related to path used here)
BTW, this .travis config which use --ignore-platform-reqs and force SERVICE_MANAGER_VERSION="^2.7.5" which is different from composer.json seems terribly ugly.
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So related to some change in restoreAutoloadFunctions.
Reverting this function to the one from 2.6 solves it.
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the Travis config:
--ignore-platorm-reqs
existed to allow testing against php 7 before composer supported the||
notation for dependency constraints. IIRC, it's also needed to allow installation on HHVM.Regarding your statement:
Can you explain what "this function" refers to? Where are you seeing an error, exactly?
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the "restoreAutoloadFunctions" fonction.
I'm mostly offline, and will try to provide more explanation / debug / fix next week.
4db6018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by PR #32