This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Resolve modules using PHP 5.5 ::class #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@Maks3w Do you have a corresponding PR on zend-loader for the changes necessary to the |
weierophinney
added a commit
that referenced
this pull request
Jul 11, 2017
- Needed to autoload the `ListenerTestModule` namespace. - Needed to import that same namespace into the test case.
weierophinney
added a commit
that referenced
this pull request
Jul 11, 2017
weierophinney
added a commit
that referenced
this pull request
Jul 11, 2017
|
Thanks, @Maks3w; merged to develop for release with 2.8.0. |
weierophinney
added a commit
to weierophinney/zend-modulemanager
that referenced
this pull request
Nov 1, 2017
…module Per zendframework#5, non-namespaced classes can create issues within applications if they conflict with a module. In particular, `Generator` is one (as the class is non-instantiable via `new`), but this can also happen in legacy applications where a new module may exist under the same name as a defined class. This patch adds tests to ensure that the resolver prefers `Module` classes if they exist, and never loads known uninstantiable classes that always exist (specifically, `Generator`).
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for use PHP 5.5
::classfeature for module names.[modules => [FooModule::class]]Current behavior of append "\Module" at the end of the string could be deprecated.
1 test is failing due a restriction in ModuleAutoloader for only autoload FQCN ended by "\Module"