This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Extends unit tests for Page and PageFactory #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamlundrigan
approved these changes
Oct 2, 2016
weierophinney
approved these changes
Mar 22, 2017
| @@ -104,6 +104,54 @@ public function testSetShouldNotMapToSetConfigToPreventRecursion() | |||
| $this->assertEquals($options, $page->get('config')); | |||
| } | |||
|
|
|||
| /** | |||
| * @expectedException \Zend\Navigation\Exception\InvalidArgumentException | |||
There was a problem hiding this comment.
I would remove the annotation and place a setExpectedException/expectException directive immediately before the call to set(); otherwise, it's possible that the factory() method might raise the exception, and we'd not be testing the correct behavior.
I can do this on merge.
| } | ||
|
|
||
| /** | ||
| * @expectedException \Zend\Navigation\Exception\InvalidArgumentException |
| } | ||
|
|
||
| /** | ||
| * @expectedException \Zend\Navigation\Exception\InvalidArgumentException |
| } | ||
|
|
||
| /** | ||
| * @expectedException \Zend\Navigation\Exception\InvalidArgumentException |
| @@ -1167,4 +1232,18 @@ public function testSetObjectPermission() | |||
| $this->assertInstanceOf('stdClass', $page->getPermission()); | |||
| $this->assertEquals('my_permission', $page->getPermission()->name); | |||
| } | |||
|
|
|||
| /** | |||
| * @expectedException \Zend\Navigation\Exception\InvalidArgumentException | |||
weierophinney
added a commit
that referenced
this pull request
Mar 22, 2017
…y-tests Extends unit tests for Page and PageFactory
weierophinney
added a commit
that referenced
this pull request
Mar 22, 2017
|
Thanks, @froschdesign |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.