This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Fixed creationContext not being passed to abstract factory canCreate() #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @weierophinney @ezimuel |
Ocramius
added a commit
that referenced
this pull request
Jan 24, 2016
Ocramius
added a commit
that referenced
this pull request
Jan 24, 2016
Ocramius
added a commit
that referenced
this pull request
Jan 24, 2016
Ocramius
added a commit
that referenced
this pull request
Jan 24, 2016
|
@kynx merged, thanks! |
| $serviceManager = new ServiceManager(); | ||
| $pluginManager = new TestAsset\SimplePluginManager($serviceManager); | ||
| $abstractFactory = $this->prophesize(AbstractFactoryInterface::class); | ||
| $abstractFactory->canCreate($serviceManager, 'foo') |
There was a problem hiding this comment.
shouldBeCalled() should be added (as far as I remember, without shouldBeCalled this assertion does nothing actually, and changing foo to something completely different does not throw any error... but I may be wrong. Mind testing @Ocramius ?
There was a problem hiding this comment.
True. But the intention was to catch the situation where canCreate() was called with the $pluginManager instead of the $serviceManager, which it does (in a rather ugly fashion ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #78