Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Commit

Permalink
Merge branch 'hotfix/3352' into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
weierophinney committed Jan 14, 2013
158 parents 136dbdd + 8d37cd0 + 4d868a7 + 9506764 + 555cb91 + 0a0842f + b6d0c88 + 7edee62 + 60ea64c + a08bcca + b40ec3e + 63172ed + 448f428 + 92a516a + 5ecbc99 + a2df21b + 4de87f2 + 7c259ec + a22bdcb + 084ad9f + 9414e5a + 489be93 + cb39e7e + 54a28dc + c9c769e + dda791d + 70d382a + 8bbad0e + 9321185 + 7ab35a6 + b93694e + 3ea7087 + 0fe3d3a + bd5e189 + d1cba17 + 8d75392 + 3fb5b55 + 6cb0ccb + 30aa565 + 8409977 + 8074ba0 + 8f92486 + 94860d1 + 05d33c4 + 425826b + f0e91f0 + e31468f + 7d2af87 + 2e4dc80 + 19d128f + 1b9e4b2 + 1c46483 + fdda3f2 + 595fcd1 + 213395c + 8e514a8 + 2f30186 + bb4ed65 + 132d5b6 + 030ff33 + f2f20f3 + a50e133 + 4c554ee + dbfb1b8 + ccab83f + 00b350f + 78945d0 + f0e5f4b + ceb7d8c + 9e124d1 + 3de5912 + b6a974a + 10a6438 + cb6c1e7 + 18afd6c + 3baf1bd + c800904 + f52dcb8 + 126ccb2 + e7d6206 + e2d24ab + ec1abfc + 290ea90 + 9f4ca1b + edaa760 + c4c0c95 + d21f055 + 5b18029 + e6b97af + 010fb36 + 64c7b8d + 636523e + 4cc2cd6 + e34098a + 16367cd + 943c77f + 8226e5b + 0b47726 + 3cd8a03 + cc4782c + 9c653a6 + 656dbe5 + 9bce1ba + 7dc18ca + 861130d + 2d2ffbd + 4f413a5 + 2e1067a + 1d082e4 + e8aeb79 + b562091 + ff2fdc3 + 4aa72c0 + 1bb67ac + cd015c8 + 5e89910 + 0c21258 + dd54faf + 57f9063 + b88ce2e + af68643 + 06cd3b4 + 2c71b71 + ee02c35 + 9456314 + 5a77a7b + e98a077 + 738f2e6 + cb1e63c + 736df07 + d0a0154 + 990523c + 78687de + a5b6e79 + 6e9dfe9 + e201a1c + d9b45ef + 76222ad + 16d67da + 1ab2258 + b81d711 + ed2e9bc + 61efe82 + f353ea5 + 1f02519 + 58c1fe8 + ed502d9 + 2defba6 + 4885013 + 06a8384 + 17d9eed + 3b21b5d + c62101c + 909ef34 + 13d376a + 8a75367 + 98a3cf5 + a385e2a commit 0eef13a
Show file tree
Hide file tree
Showing 3 changed files with 66 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/Hydrator/ClassMethods.php
Expand Up @@ -10,6 +10,7 @@

namespace Zend\Stdlib\Hydrator;

use ReflectionMethod;
use Zend\Stdlib\Exception;

/**
Expand Down Expand Up @@ -103,6 +104,11 @@ public function extract($object)
continue;
}

$reflectionMethod = new ReflectionMethod(get_class($object) . '::' . $method);
if ($reflectionMethod->getNumberOfParameters() > 0) {
continue;
}

$attribute = $method;
if (preg_match('/^get/', $method)) {
$attribute = substr($method, 3);
Expand Down
17 changes: 17 additions & 0 deletions test/HydratorTest.php
Expand Up @@ -15,6 +15,7 @@
use ZendTest\Stdlib\TestAsset\ClassMethodsCamelCase;
use ZendTest\Stdlib\TestAsset\ClassMethodsUnderscore;
use ZendTest\Stdlib\TestAsset\ClassMethodsCamelCaseMissing;
use ZendTest\Stdlib\TestAsset\ClassMethodsInvalidParameter;
use ZendTest\Stdlib\TestAsset\Reflection as ReflectionAsset;
use Zend\Stdlib\Hydrator\Strategy\DefaultStrategy;
use Zend\Stdlib\Hydrator\Strategy\SerializableStrategy;
Expand Down Expand Up @@ -43,6 +44,11 @@ class HydratorTest extends \PHPUnit_Framework_TestCase
*/
protected $classMethodsUnderscore;

/**
* @var ClassMethodsInvalidParameter
*/
protected $classMethodsInvalidParameter;

/**
* @var ReflectionAsset
*/
Expand All @@ -53,6 +59,7 @@ public function setUp()
$this->classMethodsCamelCase = new ClassMethodsCamelCase();
$this->classMethodsCamelCaseMissing = new ClassMethodsCamelCaseMissing();
$this->classMethodsUnderscore = new ClassMethodsUnderscore();
$this->classMethodsInvalidParameter = new ClassMethodsInvalidParameter();
$this->reflection = new ReflectionAsset;
}

Expand Down Expand Up @@ -248,4 +255,14 @@ public function testHydratorClassMethodsCamelCaseWithSetterMissing()
$this->assertEquals($test->getFooBar(), 'foo');
$this->assertEquals($test->getFooBarBaz(), '2');
}

public function testHydratorClassMethodsWithServiceManager()
{
$hydrator = new ClassMethods(false);
$datas = $hydrator->extract($this->classMethodsInvalidParameter);

$this->assertTrue($datas['hasBar']);
$this->assertEquals('Bar', $datas['foo']);
$this->assertFalse($datas['isBla']);
}
}
43 changes: 43 additions & 0 deletions test/TestAsset/ClassMethodsInvalidParameter.php
@@ -0,0 +1,43 @@
<?php
/**
* Zend Framework (http://framework.zend.com/)
*
* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
* @license http://framework.zend.com/license/new-bsd New BSD License
* @package Zend_Stdlib
*/
namespace ZendTest\Stdlib\TestAsset;

class ClassMethodsInvalidParameter
{
public function hasAlias($alias)
{
return $alias;
}

public function getTest($foo)
{
return $foo;
}

public function isTest($bar)
{
return $bar;
}

public function hasBar()
{
return true;
}

public function getFoo()
{
return "Bar";
}

public function isBla()
{
return false;
}
}

0 comments on commit 0eef13a

Please sign in to comment.