zendframework/zendframework#6523 - cs fixes, minor cleanups

zendframework · Jan 1, 2015 · 8420083 · 8420083
1 parent 33067be
commit 8420083
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/src/Hydrator/Strategy/BooleanStrategy.php b/src/Hydrator/Strategy/BooleanStrategy.php
@@ -21,12 +21,12 @@ class BooleanStrategy implements StrategyInterface
     /**
      * @var int|string
      */
-    protected $trueValue;
+    private $trueValue;
 
     /**
      * @var int|string
      */
-    protected $falseValue;
+    private $falseValue;
 
     /**
      * @param int|string $trueValue
@@ -49,7 +49,7 @@ public function __construct($trueValue, $falseValue)
             ));
         }
 
-        $this->trueValue = $trueValue;
+        $this->trueValue  = $trueValue;
         $this->falseValue = $falseValue;
     }
 
@@ -69,11 +69,7 @@ public function extract($value)
             ));
         }
 
-        if ($value === true) {
-            return $this->trueValue;
-        }
-
-        return $this->falseValue;
+        return $value === true ? $this->trueValue : $this->falseValue;
     }
 
     /**
@@ -107,5 +103,4 @@ public function hydrate($value)
             $this->falseValue
         ));
     }
-
 }