Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Renaming ErrorHandler to ErrorHandlerMiddleware #191

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Renaming ErrorHandler to ErrorHandlerMiddleware #191

wants to merge 6 commits into from

Commits on Aug 19, 2019

  1. Added missing properties to ErrorHandlerTest

    @boesing
    boesing committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    a523e37 View commit details
    Browse the repository at this point in the history

  2. Introducing ErrorMiddleware 

    The `ErrorMiddleware` is just a drop-in replacement for the `ErrorHandler` to solve a naming conflict.
As the `ErrorHandler` is implementing the `MiddlewareInterface`, it supposed to be called `ErrorMiddleware` instead.
    @boesing
    boesing committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    b5bfa34 View commit details
    Browse the repository at this point in the history

  3. Marking ErrorHandler deprecated 

    The `ErrorHandler` should be removed in v4.
    @boesing
    boesing committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    aaed976 View commit details
    Browse the repository at this point in the history

  4. ErrorHandler extends the ErrorMiddleware 

    By just extending the `ErrorMiddleware`, we can remove the dedicated unit test and the duplicated code for the `ErrorHandler`
    @boesing
    boesing committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    b1b6acf View commit details
    Browse the repository at this point in the history

  5. Renaming ErrorMiddleware to ErrorHandlerMiddleware 

    Actually, its an error handling middleware.
Renaming to `ErrorHandlerMiddleware` is more beneficial as just `ErrorMiddleware`.
    @boesing
    boesing committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    cf7793d View commit details
    Browse the repository at this point in the history

  6. Renaming the ErrorMiddlewareTest to ErrorHandlerMiddlewareTest

    @boesing
    boesing committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    46f69fe View commit details
    Browse the repository at this point in the history